search

compilatio / moodle-plagiarism_compilatio

Compilatio.net plagiarism plugin for Moodle
4 stars 9 forks source link

should not `student_disclosure` global setting be replaced by `studentdisclosuredefault` string ? #64

Open jboulen opened 2 years ago

jboulen commented 2 years ago

Hello,

Following this discussion on the French Moodle forum, is there any reason to use a global setting (that is not translatable) instead to use the studentdisclosuredefault string (available in several languages) ?

If this is a mistake, would you accept a pull request ?

Regards,

danmarsden commented 2 years ago

Isn't it translateable using standard moodle multi lang functions? It definitely is with the other plagiarism plugins I work with.

danmarsden commented 2 years ago

Similar report here: https://github.com/danmarsden/moodle-plagiarism_urkund/issues/152

jboulen commented 2 years ago

Yes, this workaround works.

But as with assignment submission agreements (see MDL-54731), I don't think this type of information should be stored in a global parameter.

I spent several minutes figuring out where this string came from. Probably many Moodle administrators would have faced the same problem. It was really not intuitive that this string was a global parameter.

Also, using a global parameter blocks all further corrections to the string. Since November 2020, this plugin uses the word similarities rather than plagiarism. However our platform still displays plagiarism. It's a minor change but the problem would have been the same if the change had been more significant.

danmarsden commented 2 years ago

I'm not the maintainer of this plugin but personally I'm not convinced.

I see this setting more as a site-policy and in many cases it should be modified by the site admin to include information linking to organisational policy - either GDPR related or linking to internal policies around authorship. For this reason it's important for many organisations to control the specific text, and relying on language maintainers to define a policy could result in a user seeing an invalid policy (the default one translated by a language translator rather than the policy specific for the organisation.)

In my opinion - the policy text should be intentionally reviewed and driven by internal policy, so if multi-language should be supported it should be translated correctly by the organisation legal team/internal privacy team to ensure that it is correct (using the multi-language feature as I suggest above.)