compilatio / moodle-plagiarism_compilatio

Compilatio.net plagiarism plugin for Moodle
4 stars 9 forks source link

Compilatio container breaks the new boost drawer layout #83

Closed Benjamin-unige closed 1 year ago

Benjamin-unige commented 1 year ago

The #compilatio-container and #compilatio-button-container elements (ie. the one displayed on assignment grading page) are printed outside of the #page element. Doing so prevents it from being properly resized when the side drawers are opened, the drawers go on top of it, obstructing the compilatio block. It also has the side effect of preventing the compilatio block to correctly scroll with the rest of the page.

The compilatio container should probably be called in the #page element or the #topofscroll .main-inner element

compilatio commented 1 year ago

Hello,

To display our container we are using the output callback hooks "before_standard_top_of_body_html" (see https://docs.moodle.org/dev/Output_callbacks). We don't control where our container is displayed.

The plagiarism function update_status that we used before and which allowed us to display our container in a better place has been deprecated (see https://tracker.moodle.org/browse/MDL-71175) and doesn't allow us to display it in forums, workshops and quizzes.

@danmarsden Is there a better solution for plugins to display content in course modules pages ?

zabellemotte commented 1 year ago

Here is the small css patch that add margins to the compilatio block to stop the block overlap:

compilatio-container{

margin: 70px 330px 20px 300px; } This is not a perfect solution but it looks better.

benoitcompilatio commented 1 year ago

Hello,

Since version 2023071800 (2.7.0) of the plugin, the Compilatio container can be minimized to prevent it from taking up a large part of the screen The container will also be improved in a future version to take up less space Having no better solution for the moment, I close this issue Feel free to reopen it if you have any suggestions

zabellemotte commented 1 year ago

We still encounter the problem with compilatio 2023071800 version. The above css works fine on this version.

zabellemotte commented 1 year ago

Here is the problem with Moodle 4.1.5+ with 2023071800 compilatio plugin. Capture d’écran 2023-08-30 à 17 31 33

zabellemotte commented 1 year ago

And here is the presentation with the css patch when blocks are unfolded ... Capture d’écran 2023-08-30 à 17 33 40

zabellemotte commented 1 year ago

And here is the presentation when blocks are folded ... It is not a perfect presentation but it is better than without it. Capture d’écran 2023-08-30 à 17 33 56

koenr commented 1 year ago

Yes, same problem here: the compilatio bar crawls under the drawers - probably because it's too wide. The whole Compilatio appearance is perceived as too intrusive on the screen by our teachers - I disabled the service in Forum for that reason. I think the top bar is unnecessary.

benoitcompilatio commented 1 year ago

Hello,

I've made a few changes to minimize the display of the Compilatio container (especially for the default display) This is available on branch 2.7.1 if you wanna test it

compilatio-container