compiler-research / CppInterOp

A Clang-based C++ Interoperability Library
Other
37 stars 20 forks source link

Running clang-tidy on PR #113

Closed Smit1603 closed 11 months ago

Smit1603 commented 11 months ago
vgvassilev commented 11 months ago

I am confused. How is clang-tidy related to code coverage?

codecov[bot] commented 11 months ago

Codecov Report

Merging #113 (489b96e) into main (0d4ab93) will increase coverage by 0.06%. The diff coverage is n/a.

:exclamation: Current head 489b96e differs from pull request most recent head 6442598. Consider uploading reports for the commit 6442598 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
+ Coverage   62.91%   62.98%   +0.06%     
==========================================
  Files          15       15              
  Lines        4061     4182     +121     
==========================================
+ Hits         2555     2634      +79     
- Misses       1506     1548      +42     

see 10 files with indirect coverage changes

see 10 files with indirect coverage changes

Smit1603 commented 11 months ago

I am confused. How is clang-tidy related to code coverage?

No sir its not related, I just found that for code coverage part also 'coverage' varible had to be implemented in matrix hence added it now. I think i might have missed earlier hence introduced it now

vgvassilev commented 11 months ago

As discussed in the last meeting we had to do some renaming. GitHub decided to close this PR probably because we rewrote our history. Can you reopen the PR against the new version of main?