compiler-research / CppInterOp

A Clang-based C++ Interoperability Library
Other
37 stars 20 forks source link

Consolidate the template instantiation logic. #128

Closed vgvassilev closed 3 months ago

vgvassilev commented 11 months ago

This patch offers a single interface for instantiation of class, function and variable templates. That would simplify user code where we do not need to care what is the underlying template pattern (most of the time).

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.24%. Comparing base (23973b8) to head (0d69570).

:exclamation: Current head 0d69570 differs from pull request most recent head 2aa6cec. Consider uploading reports for the commit 2aa6cec to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/128/graphs/tree.svg?width=650&height=150&src=pr&token=7UWTYSVVT5&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research)](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/128?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) ```diff @@ Coverage Diff @@ ## main #128 +/- ## =========================================== - Coverage 78.74% 63.24% -15.51% =========================================== Files 8 15 +7 Lines 3091 4097 +1006 =========================================== + Hits 2434 2591 +157 - Misses 657 1506 +849 ``` | [Files](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/128?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) | Coverage Δ | | |---|---|---| | [include/clang/Interpreter/CppInterOp.h](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/128?src=pr&el=tree&filepath=include%2Fclang%2FInterpreter%2FCppInterOp.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research#diff-aW5jbHVkZS9jbGFuZy9JbnRlcnByZXRlci9DcHBJbnRlck9wLmg=) | `96.29% <ø> (-3.71%)` | :arrow_down: | | [lib/Interpreter/CppInterOp.cpp](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/128?src=pr&el=tree&filepath=lib%2FInterpreter%2FCppInterOp.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research#diff-bGliL0ludGVycHJldGVyL0NwcEludGVyT3AuY3Bw) | `73.36% <100.00%> (-13.00%)` | :arrow_down: | | [unittests/CppInterOp/ScopeReflectionTest.cpp](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/128?src=pr&el=tree&filepath=unittests%2FCppInterOp%2FScopeReflectionTest.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research#diff-dW5pdHRlc3RzL0NwcEludGVyT3AvU2NvcGVSZWZsZWN0aW9uVGVzdC5jcHA=) | `100.00% <100.00%> (ø)` | | ... and [15 files with indirect coverage changes](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/128/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) | [Files](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/128?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) | Coverage Δ | | |---|---|---| | [include/clang/Interpreter/CppInterOp.h](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/128?src=pr&el=tree&filepath=include%2Fclang%2FInterpreter%2FCppInterOp.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research#diff-aW5jbHVkZS9jbGFuZy9JbnRlcnByZXRlci9DcHBJbnRlck9wLmg=) | `96.29% <ø> (-3.71%)` | :arrow_down: | | [lib/Interpreter/CppInterOp.cpp](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/128?src=pr&el=tree&filepath=lib%2FInterpreter%2FCppInterOp.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research#diff-bGliL0ludGVycHJldGVyL0NwcEludGVyT3AuY3Bw) | `73.36% <100.00%> (-13.00%)` | :arrow_down: | | [unittests/CppInterOp/ScopeReflectionTest.cpp](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/128?src=pr&el=tree&filepath=unittests%2FCppInterOp%2FScopeReflectionTest.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research#diff-dW5pdHRlc3RzL0NwcEludGVyT3AvU2NvcGVSZWZsZWN0aW9uVGVzdC5jcHA=) | `100.00% <100.00%> (ø)` | | ... and [15 files with indirect coverage changes](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/128/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research)
maximusron commented 3 months ago

This looks good to go for the incoming template fix patch in

maximusron commented 3 months ago

@vgvassilev looks like all the bots are failing only on the cppyy and xeus builds due to the pending update in cppyy-backend https://github.com/compiler-research/cppyy-backend/pull/94

I believe this PR can be merged now