compiler-research / CppInterOp

A Clang-based C++ Interoperability Library
Other
47 stars 21 forks source link

Added Dpcumentation of cppyy Enhancements and how they relate to LibInterOp #160

Closed QuillPusher closed 9 months ago

QuillPusher commented 11 months ago
codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1fd3ae4) 72.65% compared to head (b70d157) 77.55%. Report is 15 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/160/graphs/tree.svg?width=650&height=150&src=pr&token=7UWTYSVVT5&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research)](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/160?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) ```diff @@ Coverage Diff @@ ## main #160 +/- ## ========================================== + Coverage 72.65% 77.55% +4.89% ========================================== Files 8 8 Lines 2889 2887 -2 ========================================== + Hits 2099 2239 +140 + Misses 790 648 -142 ``` [see 6 files with indirect coverage changes](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/160/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) [see 6 files with indirect coverage changes](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/160/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research)
QuillPusher commented 11 months ago

Minor review change committed and force-pushed to one commit

QuillPusher commented 10 months ago

Hello @sudo-panda and @vgvassilev ,

@davidlange6 has asked some tough questions in this review. I don't have clear answers for all. Please see the above unresolved comments and share your insights for more clarity

QuillPusher commented 9 months ago

Thanks @davidlange6 , requested changes made

QuillPusher commented 9 months ago

Thanks @vgvassilev , the requested changes have been made