search

compiler-research / CppInterOp

A Clang-based C++ Interoperability Library
Other
38 stars 20 forks source link

Updating GetBaseClass #161

Closed Smit1603 closed 8 months ago

github-actions[bot] commented 8 months ago

clang-tidy review says "All clean, LGTM! :+1:"

codecov[bot] commented 8 months ago

Codecov Report

Merging #161 (433b0b5) into main (1fd3ae4) will increase coverage by 0.10%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
+ Coverage   72.65%   72.75%   +0.10%     
==========================================
  Files           8        8              
  Lines        2889     2885       -4     
==========================================
  Hits         2099     2099              
+ Misses        790      786       -4
Files Coverage Δ
lib/Interpreter/CppInterOp.cpp 80.05% <100.00%> (+0.20%) :arrow_up:
Files Coverage Δ
lib/Interpreter/CppInterOp.cpp 80.05% <100.00%> (+0.20%) :arrow_up:
github-actions[bot] commented 8 months ago

clang-tidy review says "All clean, LGTM! :+1:"

vgvassilev commented 8 months ago

The commit message should say what the change was done for instead of which function it was in. How about something like Remove dead code since TemplateSpecializationType is a subclass for RecordType.

github-actions[bot] commented 8 months ago

clang-tidy review says "All clean, LGTM! :+1:"