Closed mcbarton closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
e61e7ca
) 78.83% compared to head (30c91dc
) 78.83%.
clang-tidy review says "All clean, LGTM! :+1:"
Can we use continue-on-error
in the yml file instead?
@vgvassilev So just to be certain before I make the change, you want me to reactivate the other Windows builds, but add continue-on-error: true to the 'Build and Test/Install CppInterOp on Windows systems' part of the jobs?
Yes, assuming we still get some green/ or different than X build sign.
clang-tidy review says "All clean, LGTM! :+1:"
@vgvassilev After that change the Windows builds now get a green tick. I have added a comment to this section that tests are expected to fail until https://github.com/compiler-research/CppInterOp/issues/188 is resolved.
@vgvassilev Can this PR be merged now that is gets a green tick for all the jobs?
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
@alexander-penev can you review this PR for me? The purpose of the PR is to do 3 things 1) Enable the ability to build CppInterOp on Windows with a different compiler to MSVC 2) Add 'continue on error' for CppInterOp build on Windows until codebase can be changed for tests to pass 3) Add osx 14 + osx arm build to CI (cc: @vgvassilev new addition)
@vgvassilev This PR allows for those trying to solve Windows build issues to use a different compiler to MSVC . With these changes I was able to compile CppInterOp and its tests using the Clang compiler. Currently I'm not passing the tests as the header files cannot be found, but I believe this has something to do with the environment variables I have set, and am investigating.
Fixes https://github.com/compiler-research/CppInterOp/issues/175 (provides proof that earlier PR fixed it)