compiler-research / CppInterOp

A Clang-based C++ Interoperability Library
Other
38 stars 20 forks source link

Re-enable win tests #206

Open vgvassilev opened 3 months ago

vgvassilev commented 3 months ago

@mcbarton, @fsfod, do you have a clue why, although gtest is passing, on windows we get:

  2/2 Test #2: cppinterop-DynamicLibraryManagerTests ...   Passed    0.02 sec

  100% tests passed, 0 tests failed out of 2

  Label Time Summary:
  DEPENDS    =  13.82 sec*proc (2 tests)

  Total Test time (real) =  13.94 sec
  Building Custom Rule D:/a/CppInterOp/CppInterOp/unittests/CMakeLists.txt
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Microsoft\VC\v170\Microsoft.CppCommon.targets(254,5): error MSB8066: Custom build for 'D:\a\CppInterOp\CppInterOp\build\CMakeFiles\f59abe5bb8dc1f8e4095ecae6605a895\check-cppinterop.rule;D:\a\CppInterOp\CppInterOp\unittests\CMakeLists.txt' exited with code -1. [D:\a\CppInterOp\CppInterOp\build\unittests\check-cppinterop.vcxproj]

More here.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.74%. Comparing base (a6f001d) to head (1b6cda0). Report is 55 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/206/graphs/tree.svg?width=650&height=150&src=pr&token=7UWTYSVVT5&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research)](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/206?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) ```diff @@ Coverage Diff @@ ## main #206 +/- ## ======================================= Coverage 78.74% 78.74% ======================================= Files 8 8 Lines 3091 3091 ======================================= Hits 2434 2434 Misses 657 657 ```
github-actions[bot] commented 3 months ago

clang-tidy review says "All clean, LGTM! :+1:"

mcbarton commented 3 months ago

@vgvassilev I don't know exactly what is causing it to fail . The only thing I can tell from a quick glance is that it appears to have an issue with this line https://github.com/vgvassilev/CppInterOp/blob/1b6cda034fe805f3f9306b35737655631662e6dd/unittests/CMakeLists.txt#L44-L45