search

compiler-research / CppInterOp

A Clang-based C++ Interoperability Library
Other
38 stars 20 forks source link

Only run clang-tidy-review on request in PR's #222

Closed maximusron closed 2 months ago

maximusron commented 2 months ago

Prevents the actions bot from spamming PR's with comments. This migrates the clang-tidy-review to be performed only when requested by detecting "clang-tidy-review" in the comment body of the PR.

vgvassilev commented 2 months ago

Shouldn't we suppress the false positives for the project that's issued by clang-tidy and address all of the rest of its comments?

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.90%. Comparing base (1272d1b) to head (3c2c5a9). Report is 2 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/222/graphs/tree.svg?width=650&height=150&src=pr&token=7UWTYSVVT5&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research)](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/222?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) ```diff @@ Coverage Diff @@ ## main #222 +/- ## ========================================== - Coverage 78.82% 77.90% -0.92% ========================================== Files 8 8 Lines 3102 3059 -43 ========================================== - Hits 2445 2383 -62 - Misses 657 676 +19 ``` [see 5 files with indirect coverage changes](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/222/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) [see 5 files with indirect coverage changes](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/222/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research)