search

compiler-research / CppInterOp

A Clang-based C++ Interoperability Library
Other
38 stars 20 forks source link

Reduce cache size #229

Closed mcbarton closed 2 months ago

mcbarton commented 2 months ago

@vgvassilev can you clear the cache, and then manually rerun the workflow of this PR? It should pass, while having a reduced llvm cache, based on the workflow in xeus-clang-repl.

vgvassilev commented 2 months ago

Why are we still building a cache for clang-18? Should we not get it via the package manager?

mcbarton commented 2 months ago

Why are we still building a cache for clang-18? Should we not get it via the package manager?

We can get rid of it via a package manager, but not for all systems yet (osx Homebrew doesn't currently have llvm 18, but its in progress). Its also not available through Emscripten forge yet for the web assembley. I think we'll be able to remove the llvm 18 cache, but not for a few weeks. This PR should significantly reduce the size of the cache if it works. The cache will also be reduce even more when I put in my PR which removes the osx x86 jobs.

mcbarton commented 2 months ago

@vgvassilev I won't be able to be certain this PR works until the cache is cleared and the workflow is run manually.

vgvassilev commented 2 months ago

Yes, just waiting for a job to finish and I will merge it.

mcbarton commented 2 months ago

Yes, just waiting for a job to finish and I will merge it.

I wouldn't merge this one yet until its been able to be tested. I'm not 100 % sure this PR works.

vgvassilev commented 2 months ago

Yes, just waiting for a job to finish and I will merge it.

I wouldn't merge this one yet until its been able to be tested. I'm not 100 % sure this PR works.

I reran with the cache cleared and indeed you are right we might need to improve this PR.

mcbarton commented 2 months ago

@vgvassilev can you clear the cache and rerun this PR?

vgvassilev commented 2 months ago

Done.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.25%. Comparing base (e639070) to head (b598dbb). Report is 7 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/229/graphs/tree.svg?width=650&height=150&src=pr&token=7UWTYSVVT5&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research)](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/229?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) ```diff @@ Coverage Diff @@ ## main #229 +/- ## ========================================== + Coverage 77.75% 79.25% +1.50% ========================================== Files 8 8 Lines 2949 3100 +151 ========================================== + Hits 2293 2457 +164 + Misses 656 643 -13 ``` [see 8 files with indirect coverage changes](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/229/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) [see 8 files with indirect coverage changes](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/229/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research)
mcbarton commented 2 months ago

@vgvassilev This PR is ready for merging. I recommend clearing the cache before merging.