search

compiler-research / CppInterOp

A Clang-based C++ Interoperability Library
Other
38 stars 20 forks source link

[ci] Cppyy tests - fix pytest failing #233

Closed maximusron closed 2 months ago

mcbarton commented 2 months ago

@maximusron The cppyy tests on osx arm still don't run after this change, but the osx x86 do (discluding the cling based one). It shouldn't be an issue, but can you turn off the parallel running of the tests for a run, so we can rule that out as an issue?

vgvassilev commented 2 months ago

When a test crashes it crashes it cannot run the subsequent test cases. The pydist did that in a distributed way so that each test case gets run in isolation and if it crashes then we still get to see if others succeeded...

maximusron commented 2 months ago

@vgvassilev Maybe once the checks are done we can merge this so that we can see the test stats on main

mcbarton commented 2 months ago

@maximusron can you rebase and fix the comment I made about apt not being present on osx in this PR https://github.com/compiler-research/CppInterOp/pull/231? Without it the packges you added for tests on Ubuntu won't be present on osx

vgvassilev commented 2 months ago

I do not understand what’s the intent of removing pydist. The other changes seem fine.

maximusron commented 2 months ago

I do not understand what’s the intent of removing pydist. The other changes seem fine.

pydist is no longer being removed, that commit has been dropped