search

compiler-research / CppInterOp

A Clang-based C++ Interoperability Library
Other
38 stars 20 forks source link

Reduce windows cache size + add options needed for wasm build of CppInterOp on Windows to llvm cache #249

Closed mcbarton closed 2 months ago

mcbarton commented 2 months ago

@vgvassilev This PR contains 2 commits. One should reduce the size of the llvm cache on Windows. The second changes the options when building llvm on Windows to allow a wasm build of CppInterOp on Windows to be added to the ci in a future PR. To test this PR you will need to clear the Windows builds in the cache, and rerun in workflow manually.

vgvassilev commented 2 months ago

@vgvassilev This PR contains 2 commits. One should reduce the size of the llvm cache on Windows. The second changes the options when building llvm on Windows to allow a wasm build of CppInterOp on Windows to be added to the ci in a future PR. To test this PR you will need to clear the Windows builds in the cache, and rerun in workflow manually.

@mcbarton, done, let's see...

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.37%. Comparing base (f93e7b6) to head (3bac975). Report is 7 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/249/graphs/tree.svg?width=650&height=150&src=pr&token=7UWTYSVVT5&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research)](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/249?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) ```diff @@ Coverage Diff @@ ## main #249 +/- ## ========================================== - Coverage 87.65% 79.37% -8.29% ========================================== Files 4 8 +4 Lines 1742 2982 +1240 ========================================== + Hits 1527 2367 +840 - Misses 215 615 +400 ``` [see 8 files with indirect coverage changes](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/249/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) [see 8 files with indirect coverage changes](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/249/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research)
mcbarton commented 2 months ago

@vgvassilev This PR works as intended so can be merged now. I recommend you clear the cache before merging, when no other workflows are running. @alexander-penev @maximusron I also recommend you put in no new PRs, or commits to current PRs until the cache has been rebuilt after merging. This is to stop these PRs making there own cache, which will overwhelm the cache size limit.