Open maximusron opened 2 months ago
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 54.76%. Comparing base (
114b3ff
) to head (c3c8510
).
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
@mcbarton, our cache sizes nowadays allow for having 1-2 osx-x86 builds. Are they easy to bring back?
@mcbarton, our cache sizes nowadays allow for having 1-2 osx-x86 builds. Are they easy to bring back?
@vgvassilev Yes, they are easy to bring back. I'll put in a PR which brings them back.
@mcbarton, our cache sizes nowadays allow for having 1-2 osx-x86 builds. Are they easy to bring back?
@vgvassilev Yes, they are easy to bring back. I'll put in a PR which brings them back.
Nice! Thanks for the speed-of-light reply and PR!
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
Adding fix from
This adds the
find_dynamic_unwind_sections
callback, used by libunwind to fix thelibc++abi: terminating due to uncaught exception of type int
on apple silicon. This returns fake_mach_header as the header for all JIT'd code.The checks are performed during library loading and unloading time, and so have been added during interpreter creation and destruction called in
CppInterOp.cpp
, via the leakedcompat::Interpreter
class