compiler-research / CppInterOp

A Clang-based C++ Interoperability Library
Other
38 stars 20 forks source link

Fix clang tidy + remove warnings when building #272

Closed mcbarton closed 1 month ago

mcbarton commented 1 month ago

@vgvassilev This is the PR to correct the bug introduced in clang tidy workflow in https://github.com/compiler-research/CppInterOp/pull/269, found in https://github.com/vgvassilev/clad/pull/883 . Once it is has been found to work in Clad this can be merged immediately.

github-actions[bot] commented 1 month ago

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] commented 1 month ago

clang-tidy review says "All clean, LGTM! :+1:"

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.45%. Comparing base (f93e7b6) to head (88ddb3e). Report is 21 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/272/graphs/tree.svg?width=650&height=150&src=pr&token=7UWTYSVVT5&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research)](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/272?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) ```diff @@ Coverage Diff @@ ## main #272 +/- ## =========================================== - Coverage 87.65% 75.45% -12.21% =========================================== Files 4 8 +4 Lines 1742 2994 +1252 =========================================== + Hits 1527 2259 +732 - Misses 215 735 +520 ``` | [Files](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/272?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) | Coverage Δ | | |---|---|---| | [lib/Interpreter/Compatibility.h](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/272?src=pr&el=tree&filepath=lib%2FInterpreter%2FCompatibility.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research#diff-bGliL0ludGVycHJldGVyL0NvbXBhdGliaWxpdHkuaA==) | `92.17% <ø> (-7.83%)` | :arrow_down: | | [lib/Interpreter/CppInterOp.cpp](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/272?src=pr&el=tree&filepath=lib%2FInterpreter%2FCppInterOp.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research#diff-bGliL0ludGVycHJldGVyL0NwcEludGVyT3AuY3Bw) | `82.14% <100.00%> (-5.06%)` | :arrow_down: | | [lib/Interpreter/DynamicLibraryManager.cpp](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/272?src=pr&el=tree&filepath=lib%2FInterpreter%2FDynamicLibraryManager.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research#diff-bGliL0ludGVycHJldGVyL0R5bmFtaWNMaWJyYXJ5TWFuYWdlci5jcHA=) | `74.03% <100.00%> (ø)` | | | [lib/Interpreter/Paths.cpp](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/272?src=pr&el=tree&filepath=lib%2FInterpreter%2FPaths.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research#diff-bGliL0ludGVycHJldGVyL1BhdGhzLmNwcA==) | `34.69% <100.00%> (ø)` | | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/272/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) | [Files](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/272?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) | Coverage Δ | | |---|---|---| | [lib/Interpreter/Compatibility.h](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/272?src=pr&el=tree&filepath=lib%2FInterpreter%2FCompatibility.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research#diff-bGliL0ludGVycHJldGVyL0NvbXBhdGliaWxpdHkuaA==) | `92.17% <ø> (-7.83%)` | :arrow_down: | | [lib/Interpreter/CppInterOp.cpp](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/272?src=pr&el=tree&filepath=lib%2FInterpreter%2FCppInterOp.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research#diff-bGliL0ludGVycHJldGVyL0NwcEludGVyT3AuY3Bw) | `82.14% <100.00%> (-5.06%)` | :arrow_down: | | [lib/Interpreter/DynamicLibraryManager.cpp](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/272?src=pr&el=tree&filepath=lib%2FInterpreter%2FDynamicLibraryManager.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research#diff-bGliL0ludGVycHJldGVyL0R5bmFtaWNMaWJyYXJ5TWFuYWdlci5jcHA=) | `74.03% <100.00%> (ø)` | | | [lib/Interpreter/Paths.cpp](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/272?src=pr&el=tree&filepath=lib%2FInterpreter%2FPaths.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research#diff-bGliL0ludGVycHJldGVyL1BhdGhzLmNwcA==) | `34.69% <100.00%> (ø)` | | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/272/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research)