compiler-research / CppInterOp

A Clang-based C++ Interoperability Library
Other
38 stars 20 forks source link

Run wasm build unconditionally in the ci #276

Closed mcbarton closed 1 month ago

mcbarton commented 1 month ago

Fixes https://github.com/compiler-research/CppInterOp/issues/274 This PR will change it so the wasm builds in the ci occur regardless of the outcome of the non wasm jobs. The reason the dependence was there previously was due to build times being large, but this is no longer the case.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.45%. Comparing base (f93e7b6) to head (dc2e322). Report is 25 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/276/graphs/tree.svg?width=650&height=150&src=pr&token=7UWTYSVVT5&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research)](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/276?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) ```diff @@ Coverage Diff @@ ## main #276 +/- ## =========================================== - Coverage 87.65% 75.45% -12.21% =========================================== Files 4 8 +4 Lines 1742 2994 +1252 =========================================== + Hits 1527 2259 +732 - Misses 215 735 +520 ``` [see 8 files with indirect coverage changes](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/276/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) [see 8 files with indirect coverage changes](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/276/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research)
mcbarton commented 1 month ago

@vgvassilev @maximusron can one of you merge this PR? It just changes the dependence of the matrix which the wasm build is dependent on, so it will run unconditionally. It also fixes the mamba envirnoment such that the was builds pass.

vgvassilev commented 1 month ago

Thank you!