search

compiler-research / CppInterOp

A Clang-based C++ Interoperability Library
Other
38 stars 20 forks source link

Fix warning micromamba envirnoment setup ci #282

Closed mcbarton closed 1 month ago

mcbarton commented 1 month ago

This PR is part of the node 16 to node 20 transition. It should stop the warning appearing when the ci runs due to the provision-with-micromamba action.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.31%. Comparing base (f93e7b6) to head (df10fc0). Report is 30 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/282/graphs/tree.svg?width=650&height=150&src=pr&token=7UWTYSVVT5&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research)](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/282?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) ```diff @@ Coverage Diff @@ ## main #282 +/- ## =========================================== - Coverage 87.65% 54.31% -33.35% =========================================== Files 4 8 +4 Lines 1742 2957 +1215 =========================================== + Hits 1527 1606 +79 - Misses 215 1351 +1136 ``` [see 8 files with indirect coverage changes](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/282/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) [see 8 files with indirect coverage changes](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/282/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research)
mcbarton commented 1 month ago

@vgvassilev can this PR be merged? It is part of the node 16 to node 20 transition. After this is merged only the Windows errors will need to be dealth with when the ci runs to have no errors or warnings.

maximusron commented 1 month ago

this looks good, but the codecov has dropped very drastically.. we should investigate this...

I tried looking into codecov reports with miromamba and couldn't find much. however. I did notice that both this and the other PR have dropped the codecoverage by the same number, see https://app.codecov.io/gh/compiler-research/CppInterOp/pulls

mcbarton commented 1 month ago

this looks good, but the codecov has dropped very drastically.. we should investigate this...

I tried looking into codecov reports with miromamba and couldn't find much. however. I did notice that both this and the other PR have dropped the codecoverage by the same number, see https://app.codecov.io/gh/compiler-research/CppInterOp/pulls

@maximusron The drop in codecov drop has nothing to do with this PR. It dropped when we stopped having coverage turned to true in all Ubuntu jobs. The coverage number on the main branch is not updating from the 88%, after that PR merge seems to be the issue.

mcbarton commented 1 month ago

@vgvassilev The issue with the coverage number not updating on the main is due to the token issue just like in xeus-cpp. Can you fix it like you did xeus-cpp repo? Error message can be seen on the nightly runs of the ci on main. Error: Codecov token not found. Please provide Codecov token with -t flag.

mcbarton commented 1 month ago

@maximusron can you merge this now that I have outlined the issue with the coverage in an issue? It has nothing to do with this PR, but a new condition on coverage report uploading and tokens.