compiler-research / CppInterOp

A Clang-based C++ Interoperability Library
Other
38 stars 20 forks source link

[ci] Add token to upload codecov reports #285

Closed maximusron closed 1 month ago

maximusron commented 1 month ago

Fixes #284

vgvassilev commented 1 month ago

We need to update the commit message, too.

vgvassilev commented 1 month ago

This fails because a new valgrind gem has showed up...

maximusron commented 1 month ago

This fails because a new valgrind gem has showed up...

Looks like we see this on all current PR's and main, with clang 17 and 18. New detected uninitialised values in ScopeReflectionTest_IncludeVector orginating from llvm::APInt::setBits. Could this be because of some new patch in clang-repl?

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.31%. Comparing base (f93e7b6) to head (df9a664). Report is 32 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/285/graphs/tree.svg?width=650&height=150&src=pr&token=7UWTYSVVT5&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research)](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/285?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) ```diff @@ Coverage Diff @@ ## main #285 +/- ## =========================================== - Coverage 87.65% 54.31% -33.35% =========================================== Files 4 8 +4 Lines 1742 2957 +1215 =========================================== + Hits 1527 1606 +79 - Misses 215 1351 +1136 ``` [see 8 files with indirect coverage changes](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/285/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) [see 8 files with indirect coverage changes](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/285/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research)
vgvassilev commented 1 month ago

We should see if we can reproduce it in a debug build.

maximusron commented 1 month ago

@vgvassilev Looks like it works now, this failure should disappear on all PR's by rebasing

maximusron commented 1 month ago

@vgvassilev This is ready to merge