Open maximusron opened 1 month ago
@maximusron If this works you'll want to wipe the cache the cache this PR made before merging, and delete the Ubuntu cache on the main too.
@maximusron can you link this PR to https://github.com/compiler-research/CppInterOp/issues/265 ?
@maximusron can you link this PR to #265 ?
Yeah sure, this PR was meant to just fix the cppyy-backend issue but if this works then maybe we can just upgrade the ubuntu versions with this. Ideally we shouldn't have to change anything on the cppyy-backend side but I am still investigating that
@maximusron Is the commit where you removed -DLLVM_ENABLE_WERROR=On temporary while you debug this PR?
@mcbarton yep its temporary, but we have another set of warnings that emerge on ubuntu 24 that we need to fix. On this PR, I removed it since we would error out on the build CppInterOp step. This may happen everytime we change the os/platform/gcc/clang
@mcbarton yep its temporary, but we have another set of warnings that emerge on ubuntu 24 that we need to fix. On this PR, I removed it since we would error out on the build CppInterOp step. This may happen everytime we change the os/platform/gcc/clang
Yes, and as part of this change we will fix them. Otherwise people commit stuff with warnings which are actually real issues...
@vgvassilev yes I have only removed it fix the pypi issue, theres something in the pyproject.toml file that needs to be changed for no-pep to work. Once that worked I thought we can fix the new warnings before merging
@maximusron The ci won't run on this PR until you have resolve the merge conflicts
Meant to fix #265
The CI seems to be picking up
cppyy-cling
from master when the backend install fails and uses an includeRTypes.h
used for ROOT. Specificallystrlcpy.h
which was copied to fix issues with Clang parsing gcc headers. These are BSD only string functions and not part of any standard, and declared incling/src/core/clib
:Ideally we should update the header guards for ubuntu 24 but in our case we don't use
cppyy-cling
, nor does our fork have those files. pip defaults to downloading and using the tarball for upstream cppyy-backend which causes this mess. Defaulting to cmake could fix this