compiler-research / CppInterOp

A Clang-based C++ Interoperability Library
Other
38 stars 20 forks source link

Fix bug due to swiftlint osx jobs ci #291

Closed mcbarton closed 1 month ago

mcbarton commented 1 month ago

@vgvassilev @maximusron can one of you merge this into the main to fix the issue with osx x86 jobs? I know this fix works as I'm currently using it in my PR on treating all warnings as errors.

maximusron commented 1 month ago

@mcbarton will do once the checks are done

maximusron commented 1 month ago

@mcbarton we need the cache from PR #281 since LLVM has to be built after valgrind. I will rerun these jobs to avoid both of them building a cache at the same time

mcbarton commented 1 month ago

@maximusron The cache from both PRs can't clash since there isn't a Ubuntu cache on the main anymore. One PR cannot pickup the cache from another PR. This PR also has nothing to do with caching. It is just removing a package which causes issues on osx. Unsure why the ci run had to be cancelled.

maximusron commented 1 month ago

Yes, I cleared the main cache for the same reason I mentioned above. That's why I would prefer that this PR doesn't also build a cache at the same time. Once the new cache is built, this PR can just use that and make things more simple (instead of having to clear this cache too once this is done).

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.31%. Comparing base (114b3ff) to head (1e928f8).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/291/graphs/tree.svg?width=650&height=150&src=pr&token=7UWTYSVVT5&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research)](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/291?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) ```diff @@ Coverage Diff @@ ## main #291 +/- ## ======================================= Coverage 54.31% 54.31% ======================================= Files 8 8 Lines 2957 2957 ======================================= Hits 1606 1606 Misses 1351 1351 ```