search

compiler-research / CppInterOp

A Clang-based C++ Interoperability Library
Other
38 stars 20 forks source link

Remove hardcoding of CMAKE_PREFIX_PATH wasm build #292

Closed mcbarton closed 1 month ago

mcbarton commented 1 month ago

For some reason CMAKE_PREFIX_PATH was hardcoded in the wasm builds. This has been corrected to be dependent on an environment variable.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.31%. Comparing base (f20c606) to head (c2503f7).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/292/graphs/tree.svg?width=650&height=150&src=pr&token=7UWTYSVVT5&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research)](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/292?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) ```diff @@ Coverage Diff @@ ## main #292 +/- ## ======================================= Coverage 54.31% 54.31% ======================================= Files 8 8 Lines 2957 2957 ======================================= Hits 1606 1606 Misses 1351 1351 ```
mcbarton commented 1 month ago

@vgvassilev can this PR be merged?