compiler-research / CppInterOp

A Clang-based C++ Interoperability Library
Other
38 stars 20 forks source link

Fix wasm build ci #296

Closed mcbarton closed 1 month ago

mcbarton commented 1 month ago

This PR will fix the broken wasm builds in the ci Fixes https://github.com/compiler-research/CppInterOp/issues/294

maximusron commented 1 month ago

@mcbarton we have a failure on main(unittest/FunctionReflectionTest:Construct) which is also failing on the same commit that was passing earlier which leads me to believe we might need to rebuild the cache since the warnings PR did not build its own. would now be a good time or would you like to push more commits?

mcbarton commented 1 month ago

@maximusron This PR is not ready. Rebuild the cache and I will revisit this PR tomorrow to fix the wasm jobs.

vgvassilev commented 1 month ago

Are we keeping the debug statements?

mcbarton commented 1 month ago

Are we keeping the debug statements?

The debug statements are not staying. They are just there because the PR is not currently working. I'm trying to work out why ;dev is still in the version name in the config file.

mcbarton commented 1 month ago

@vgvassilev The debug run says this is doing what is expected. The ;dev in the version number in the config file is coming from somewhere else. Any ideas where?

vgvassilev commented 1 month ago

Here: https://github.com/compiler-research/CppInterOp/blob/main/cmake/CppInterOp/CppInterOpConfigVersion.cmake.in ?

maximusron commented 1 month ago

@mcbarton looks like this should be good to go now(based on the passing wasm builds). Let's rebase with main and squash before the last checks are done just to be sure

mcbarton commented 1 month ago

@mcbarton looks like this should be good to go now(based on the passing wasm builds). Let's rebase with main before the last checks are done just to be sure

@maximusron I think it is ok too. I've just done a cleanup of things I think are unneeded changes. Once the changes pass I will rebase.

maximusron commented 1 month ago

sounds good

maximusron commented 1 month ago

I'm going to cancel the run on main to speed this up

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.22%. Comparing base (c8979a2) to head (f38a728).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/296/graphs/tree.svg?width=650&height=150&src=pr&token=7UWTYSVVT5&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research)](https://app.codecov.io/gh/compiler-research/CppInterOp/pull/296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) ```diff @@ Coverage Diff @@ ## main #296 +/- ## ======================================= Coverage 72.22% 72.22% ======================================= Files 8 8 Lines 2963 2963 ======================================= Hits 2140 2140 Misses 823 823 ```
maximusron commented 1 month ago

@mcbarton can you rebase into a single commit before the checks?

mcbarton commented 1 month ago

@mcbarton can you rebase into a single commit before the checks?

I will rebase it in around 1-2 hours time. I am away from my computer until then.