Closed mcbarton closed 1 month ago
@mcbarton we have a failure on main(unittest/FunctionReflectionTest:Construct) which is also failing on the same commit that was passing earlier which leads me to believe we might need to rebuild the cache since the warnings PR did not build its own. would now be a good time or would you like to push more commits?
@maximusron This PR is not ready. Rebuild the cache and I will revisit this PR tomorrow to fix the wasm jobs.
Are we keeping the debug statements?
Are we keeping the debug statements?
The debug statements are not staying. They are just there because the PR is not currently working. I'm trying to work out why ;dev is still in the version name in the config file.
@vgvassilev The debug run says this is doing what is expected. The ;dev in the version number in the config file is coming from somewhere else. Any ideas where?
@mcbarton looks like this should be good to go now(based on the passing wasm builds). Let's rebase with main and squash before the last checks are done just to be sure
@mcbarton looks like this should be good to go now(based on the passing wasm builds). Let's rebase with main before the last checks are done just to be sure
@maximusron I think it is ok too. I've just done a cleanup of things I think are unneeded changes. Once the changes pass I will rebase.
sounds good
I'm going to cancel the run on main to speed this up
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 72.22%. Comparing base (
c8979a2
) to head (f38a728
).
@mcbarton can you rebase into a single commit before the checks?
@mcbarton can you rebase into a single commit before the checks?
I will rebase it in around 1-2 hours time. I am away from my computer until then.
This PR will fix the broken wasm builds in the ci Fixes https://github.com/compiler-research/CppInterOp/issues/294