Implemented GetFunctionArgDefault Module

compiler-research / CppInterOp

A Clang-based C++ Interoperability Library

Other

43 stars 21 forks source link

Closed Smit1603 closed 1 year ago

Smit1603 commented 1 year ago

Smit1603 commented 1 year ago

As per above discussion I have made few changes
As mentioned , I tried with default value for float as 3.123 , and I was quite stunned that test case failed as module returned default value as 3.1230000001
Hence in order to remove above error I implemented another conditional statement for float and double type arguments and tried on some new test cases
Finally recieved correct output
@vgvassilev and @sudo-panda Kindly review changes made and pls let me know whether any other changes/improvements are required

Smit1603 commented 1 year ago

@vgvassilev I have added a FIXME which is explaining the problem, could you pls review it and pls tell me whether I should still use round mode (as clarification for not using it was given in previous comment)
If any further changes are required pls let me know

vgvassilev commented 1 year ago

Please rebase this PR and we will see if the tests pass.

vgvassilev commented 1 year ago

Please remove the merge commit.

vgvassilev commented 1 year ago

Do you need some help with that?

Smit1603 commented 1 year ago

@vgvassilev thank you so much for helping me with that , could you just explain me about the steps that you followed so that I could understand it correctly and will be helpful for me in future
I tried various steps but wasnt able to understand it so.....
I am Sry that I wasnt able to perform that task correctly but will definitely learn about it for future purpose