Implemented IsSubType Module Successfully

compiler-research / CppInterOp

A Clang-based C++ Interoperability Library

Other

43 stars 21 forks source link

Implemented IsSubType Module Successfully #32

Closed Smit1603 closed 1 year ago

Smit1603 commented 1 year ago

This pull request will resolve issue #18
I have implemented IsSubType Module and ran it succesfully
Kindly review it and please let me know whether any improvement or changes are required or not
@vgvassilev and @sudo-panda

Smit1603 commented 1 year ago

@vgvassilev I have made changes as mentioned by you
Kindly review and pls let me know whether any more changes/improvements are required or not

Smit1603 commented 1 year ago

@sudo-panda I have changed variables name as mentioned by you for consistency purpose
With regards to extra test cases I tried to perform multilevel inheritance and tried above implemented module and found that test gives incorrect output
So I am currently resolving that issue and will commit everything after resolving above issues
Just making sure and informing you whether I am going in correct direction???

Smit1603 commented 1 year ago

@sudo-panda as mentioned above
I have added few more test cases which can check for various types of inheritance
I have also changed variable names for consistency purpose
I hope this modified code will meet every test cases and its requirements
Pls review and let me know whether any further changes/improvements are required or not

Smit1603 commented 1 year ago

@vgvassilev and @sudo-panda pls review and let me know whether any further improvements/changes are required or not

Smit1603 commented 1 year ago

@vgvassilev sry for misconception on my side
I have modified code as mentioned by you
I hope the module is correctly implemented now
Pls review and let me know whether any further improvements are required or not

vgvassilev commented 1 year ago

@vgvassilev sry for misconception on my side

I have modified code as mentioned by you

I hope the module is correctly implemented now

Pls review and let me know whether any further improvements are required or not

Please write a good commit message and make this PR with a single commit.

Smit1603 commented 1 year ago

@vgvassilev and @sudo-panda I have squashed all commit as asked
Pls review and let me know whether is it done or not

vgvassilev commented 1 year ago

As a commit message I can suggest: "Add an API checking if a type is derived from another."

Smit1603 commented 1 year ago

@vgvassilev I hope this works