compiler-research / CppInterOp

A Clang-based C++ Interoperability Library
Other
43 stars 21 forks source link

Add support for ArrayTypes that are not ConstantArrayType in GetDimensions #46

Closed sudo-panda closed 1 year ago

sudo-panda commented 1 year ago

Uses an enum DimensionValue::UNKNOWN_SIZE to denote the size of these types.

I have used a namespace instead of an enum class for DimensionValue so that it can be implicitly converted to and from long int.

vgvassilev commented 1 year ago

This change seems to have regressed cppyy from passing 120 to 118 tests: https://github.com/compiler-research/cppyy-backend/actions/runs/4504956608/jobs/7931040048