compiler-research / compiler-research.github.io

7 stars 49 forks source link

Adding Blog Functionality and New Blog Posts #156

Closed QuillPusher closed 5 months ago

QuillPusher commented 6 months ago
davidlange6 commented 5 months ago

are the images being added here not already part of the website?

QuillPusher commented 5 months ago

@davidlange6 No, this is how it looks on my localhost after making the changes. I just shared these images to show how this change will reflect on the website after the merge

davidlange6 commented 5 months ago

eg they are here already, no https://github.com/compiler-research/compiler-research.github.io/tree/master/images/blog

QuillPusher commented 5 months ago

just found that the previous images are from a "Blog Draft" page that is not rendered anywhere on the website.

https://github.com/compiler-research/compiler-research.github.io/commit/4f92a925ef93528c7cafe6377ec81be4e6ddbe84#diff-f97301cb74fc1a8f69b28c9b1112daa77c8ec91d44d2ba2429a63420348ef279

QuillPusher commented 5 months ago

I suggest that we let my changes go in as they are, since the image files are named logically, based on blog post name. Also I formatted the images to look better with the rest of the content.

The existing images and the "_pages/blog_post.md" can perhaps be removed in a separate PR, along with other dead areas of the website that are not rendered anywhere

vgvassilev commented 5 months ago

That makes the repository bigger and the deployment of the website unnecessarily slower. Even if we delete these files afterwords they still contribute to the overall size as they are present in the repository history.

davidlange6 commented 5 months ago

and here is where they are used on the website... https://compiler-research.org/interactive_cpp best not to duplicate content

QuillPusher commented 5 months ago

On a closer look the older images are inconsistent.

Please let me know if I should revert to older images, because then that would require me deleting some images and adding some images anyway.

vgvassilev commented 5 months ago

On a closer look the older images are inconsistent.

* There is **one image missing** (cling-2020-12-21-figure3.png).

Adding this should be fine.

* One of them is a **PNG instead of a GIF** (cling-2020-12-21-figure9.gif/figure10.png) which defeats the purpose

Those are two different items then and adding the gif is probably fine.

* There's another one that's **different from the original image** (cling-2020-12-21-figure1.png/figure3.png).

Let's replace the wrong image.

* Also some of the older images are **lower resolution**.

Let's replace the lower resolution images with the higher resolution ones.

Please let me know if I should revert to older images, because then that would require me deleting some images and adding some images anyway.

We should update the ones that are crappy and add the ones that are not duplicated.

QuillPusher commented 5 months ago

Please ignore previous messages, full summary below: 🚀 🚀 🚀

BLOG

Blog