search

compiler-research / cppyy-backend

1 stars 6 forks source link

Use canon type when converting return type to str #76

Closed sudo-panda closed 1 year ago

vgvassilev commented 1 year ago

@sudo-panda do you plan to address the crashing xfail tests?

sudo-panda commented 1 year ago

Yes

sudo-panda commented 1 year ago

Depends on compiler-research/CppInterOp#107

sudo-panda commented 1 year ago

This can be merged now

vgvassilev commented 1 year ago

@sudo-panda I see the xfail tests crashing. Is that expected?

sudo-panda commented 1 year ago

I don't see any xfail tests crashing. Can you show where they are crashing?

vgvassilev commented 1 year ago

I don't see any xfail tests crashing. Can you show where they are crashing?

Here: https://github.com/compiler-research/cppyy-backend/actions/runs/5495282689/jobs/10014577462?pr=76#step:16:921 ?

sudo-panda commented 1 year ago

@vgvassilev I am not sure what happened before, but I reran the tests, and now it's showing the same as I saw before. The xfails aren't crashing anymore, so you can merge this.