search

compiler-research / cppyy-backend

1 stars 6 forks source link

Fixes issues that occur when building on Apple Silicon #88

Closed mcbarton closed 9 months ago

mcbarton commented 9 months ago

Add .dylib option when building on MacOS Disabled use of -march=native when on Apple Silicon Link to CppInterOp (without this on MacOS you get undefined symbols error when building)

mcbarton commented 9 months ago

@vgvassilev any comments on this pull request?

vgvassilev commented 9 months ago

The PR looks good to me but I am not sure why the CI does not trigger...

mcbarton commented 9 months ago

Not sure why either. My pull request doesn't touch the github workflow files, so don't believe it can anything I have done. While that is figured out I'll squash the commits into 1, and perform a git-clang format after the squash.

vgvassilev commented 9 months ago

Can you create a separate branch and open a PR from there not from your master?

mcbarton commented 9 months ago

Do you mean a separate branch on my fork and make a PR from there, or a PR on separate branch in the compiler-research repo? If it's the latter I cannot as I don't have the permissions needed to make a branch in this repo.

vgvassilev commented 9 months ago

Do you mean a separate branch on my fork and make a PR from there, or a PR on separate branch in the compiler-research repo? If it's the latter I cannot as I don't have the permissions needed to make a branch in this repo.

I meant separate branch on your fork.

mcbarton commented 9 months ago

I'll make a separate branch on my fork then, and put in a pull request for that shortly.

vgvassilev commented 9 months ago

Looks like the new PR did not help. I will merge this and see if triggers the build as part of the push to the master branch...