search

compiler-research / cppyy-backend

1 stars 6 forks source link

Fix cache ci #92

Closed mcbarton closed 7 months ago

mcbarton commented 7 months ago

@vgvassilev This PR fixes the ci cache issue noticed in https://github.com/compiler-research/cppyy-backend/pull/81 . The issue appears because even though a recursive copy works the same on my local machine for both osx and Ubuntu , it doesn't on the Github runner for some reason. Before merging this into the master branch, you should cancel any Github actions are running on the master branch (as the llvm-cache would be wrong), and check there is no cache associated with the master branch. I know the cache works or this PR, as the last workflow run for this PR makes use of it.

mcbarton commented 7 months ago

@vgvassilev in theory the commit I just pushed should fix the copy recursive issue. Can you clear the cache and manually reactivate the workflow on the PR to check?

vgvassilev commented 7 months ago

@vgvassilev in theory the commit I just pushed should fix the copy recursive issue. Can you clear the cache and manually reactivate the workflow on the PR to check?

Done.

mcbarton commented 7 months ago

@vgvassilev The cache is now working, as shown by the last ci run making use of it, and gets all green ticks. I believe this PR can now be merged.