search

compiler-research / cppyy-backend

1 stars 6 forks source link

[ci] Update cppyy testing job #96

Closed aaronj0 closed 4 months ago

aaronj0 commented 4 months ago

@vgvassilev understood, I have kept the true condition only for the crashing test runs and removed it from both the runs you addressed.

vgvassilev commented 4 months ago

@vgvassilev understood, I have kept the true condition only for the crashing test runs and removed it from both the runs you addressed.

Yes, and that's the trouble - we have regressed. We need to fix this before moving forward...

aaronj0 commented 4 months ago

@vgvassilev this PR now works as intended, could you take a look at the jobs?

On linux only clang-16 reports a failure due to valgrind. The OS X jobs are currently red because of the 33 failures due to libc++ not handling std library types like libstdc++

vgvassilev commented 4 months ago

@vgvassilev this PR now works as intended, could you take a look at the jobs?

On linux only clang-16 reports a failure due to valgrind. The OS X jobs are currently red because of the 33 failures due to libc++ not handling std library types like libstdc++

We should open an issue for these and mark them as xfail on osx.

aaronj0 commented 4 months ago

@vgvassilev This has been updated to the same as https://github.com/compiler-research/CppInterOp/pull/239, we can go ahead with the merge