search

compiler-research / xeus-cpp

Jupyter kernel for the C++ programming language
BSD 3-Clause "New" or "Revised" License
20 stars 24 forks source link

Upgraded to latest xeus (3.2.0) #103

Closed anutosh491 closed 5 months ago

anutosh491 commented 5 months ago

Fixes #94

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.83%. Comparing base (46cfe09) to head (bba7317).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/103/graphs/tree.svg?width=650&height=150&src=pr&token=9KM610P5A4&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research)](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/103?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) ```diff @@ Coverage Diff @@ ## main #103 +/- ## ======================================= Coverage 59.83% 59.83% ======================================= Files 15 15 Lines 600 600 Branches 59 59 ======================================= Hits 359 359 Misses 241 241 ```
mcbarton commented 5 months ago

@anutosh491 If this is the new minimum version, then probably worth changing the yml files for mamba development to check the ci hasn't picked up a version that's less than it.

anutosh491 commented 5 months ago

Hi @mcbarton

So I don't think we are dependent on xeus. Rather xeus is pulled by xeus-zmq so we're good if we have an upper bound on xeus-zmq (< 2.0 ). But yeah for the emscripten build we can try that.