search

compiler-research / xeus-cpp

Jupyter kernel for the C++ programming language
BSD 3-Clause "New" or "Revised" License
17 stars 24 forks source link

Attempt to removed xtl dependency #110

Closed anutosh491 closed 3 months ago

anutosh491 commented 3 months ago

Fixes #108

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.45%. Comparing base (e788167) to head (1042afb).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/110/graphs/tree.svg?width=650&height=150&src=pr&token=9KM610P5A4&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research)](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) ```diff @@ Coverage Diff @@ ## main #110 +/- ## ========================================== + Coverage 62.66% 63.45% +0.79% ========================================== Files 15 15 Lines 600 613 +13 Branches 59 60 +1 ========================================== + Hits 376 389 +13 Misses 224 224 ``` | [Files](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/110?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) | Coverage Δ | | |---|---|---| | [src/xinspect.hpp](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/110?src=pr&el=tree&filepath=src%2Fxinspect.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research#diff-c3JjL3hpbnNwZWN0LmhwcA==) | `69.49% <ø> (ø)` | | | [src/xinterpreter.cpp](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/110?src=pr&el=tree&filepath=src%2Fxinterpreter.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research#diff-c3JjL3hpbnRlcnByZXRlci5jcHA=) | `88.30% <100.00%> (+0.96%)` | :arrow_up: | | [src/xutils.cpp](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/110?src=pr&el=tree&filepath=src%2Fxutils.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research#diff-c3JjL3h1dGlscy5jcHA=) | `78.57% <ø> (ø)` | | | [Files](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/110?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) | Coverage Δ | | |---|---|---| | [src/xinspect.hpp](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/110?src=pr&el=tree&filepath=src%2Fxinspect.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research#diff-c3JjL3hpbnNwZWN0LmhwcA==) | `69.49% <ø> (ø)` | | | [src/xinterpreter.cpp](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/110?src=pr&el=tree&filepath=src%2Fxinterpreter.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research#diff-c3JjL3hpbnRlcnByZXRlci5jcHA=) | `88.30% <100.00%> (+0.96%)` | :arrow_up: | | [src/xutils.cpp](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/110?src=pr&el=tree&filepath=src%2Fxutils.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research#diff-c3JjL3h1dGlscy5jcHA=) | `78.57% <ø> (ø)` | |
github-actions[bot] commented 3 months ago

clang-tidy review says "All clean, LGTM! :+1:"

anutosh491 commented 3 months ago

Hmm wait, I think pertaining to this line https://github.com/jupyter-xeus/xeus/blob/1bbef7208ed3d92a90eadce752d3b56b7636f920/xeusConfig.cmake.in#L25, we might not be able to drop the dependency of xtl from xeus-cpp ( The dependency chain might be xeus-cpp -> xeus-zmq -> xeus -> xtl)

vgvassilev commented 3 months ago

Ah, that's a good point... :(

JohanMabille commented 3 months ago

I think most of the features we use from the xtl are actually specific to xeus, meaning we could actually move or duplicate the code in xeus. I'm not 100% sure though.