search

compiler-research / xeus-cpp

Jupyter kernel for the C++ programming language
BSD 3-Clause "New" or "Revised" License
17 stars 24 forks source link

Removing dirent dependency #113

Closed anutosh491 closed 3 months ago

anutosh491 commented 3 months ago

I don't think we use dirent for windows build anymore and can be removed.

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.09%. Comparing base (6692a45) to head (031546d). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/113/graphs/tree.svg?width=650&height=150&src=pr&token=9KM610P5A4&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research)](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/113?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) ```diff @@ Coverage Diff @@ ## main #113 +/- ## ======================================= Coverage 70.09% 70.09% ======================================= Files 17 17 Lines 602 602 Branches 59 59 ======================================= Hits 422 422 Misses 180 180 ```
anutosh491 commented 3 months ago

Ahh okay got you. So only 0.0.1 uses dirent and dirent was removed through this commit dated back to July 22, 2023 and 0.1.0 was out by Nov, 2023. So I think we can get rid of the first patch version.

Unless we are expecting people to install versions 0.0.1-0.3.0 then its probably worth removing these from the readme

Also yes, most repos from the xeus-stack keep track of minor versions so we'll keep that for now.