search

compiler-research / xeus-cpp

Jupyter kernel for the C++ programming language
BSD 3-Clause "New" or "Revised" License
17 stars 24 forks source link

Add tests for xmagics, os, xutils, xinterpreter #116

Closed tharun571 closed 3 months ago

github-actions[bot] commented 3 months ago

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] commented 3 months ago

clang-tidy review says "All clean, LGTM! :+1:"

mcbarton commented 3 months ago

sys/wait.h is for unix systems only. You will need a different header for Windows.

github-actions[bot] commented 3 months ago

clang-tidy review says "All clean, LGTM! :+1:"

mcbarton commented 3 months ago

unistd.h is also unix only.

tharun571 commented 3 months ago

@mcbarton the handler function which has backtrace and backtrace_symbols_fd are also not available in windows. Shall I change that particular test for unix only?

mcbarton commented 3 months ago

@tharun571 Maybe you could try one of the suggestions from this stackoverflow page where they talk about Windows equivalents https://stackoverflow.com/questions/341817/is-there-a-replacement-for-unistd-h-for-windows-visual-c .

tharun571 commented 3 months ago

Also is there a way to check windows build in local? or should I push the code everytime to check?

mcbarton commented 3 months ago

Also is there a way to check windows build in local? or should I push the code everytime to check?

If you have access to a Windows machine you could run the commands in the ci. There are currently no Windows instructions in the documentation. I will add at some point.

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.08%. Comparing base (6692a45) to head (2f37664). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/116/graphs/tree.svg?width=650&height=150&src=pr&token=9KM610P5A4&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research)](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/116?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) ```diff @@ Coverage Diff @@ ## main #116 +/- ## ========================================== + Coverage 70.09% 75.08% +4.98% ========================================== Files 17 17 Lines 602 602 Branches 59 59 ========================================== + Hits 422 452 +30 + Misses 180 150 -30 ``` [see 3 files with indirect coverage changes](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/116/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) [see 3 files with indirect coverage changes](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/116/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research)
github-actions[bot] commented 3 months ago

clang-tidy review says "All clean, LGTM! :+1:"

anutosh491 commented 3 months ago

Converting to draft, let us know when the PR is ready for review (after maybe squashing the commits too)

tharun571 commented 3 months ago

@anutosh491 this covers most of #114. Having some trouble with complete_request. Will push that later.

github-actions[bot] commented 3 months ago

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] commented 3 months ago

clang-tidy review says "All clean, LGTM! :+1:"