compiler-research / xeus-cpp

Jupyter kernel for the C++ programming language
BSD 3-Clause "New" or "Revised" License
17 stars 24 forks source link

Minor changes in Readme for the wasm build #117

Closed anutosh491 closed 3 months ago

anutosh491 commented 3 months ago

I think we should have the -f flag in front of the file and also no need for the -n flag. We should technically also activate the environment to use emsdk Hence the change.

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.09%. Comparing base (6692a45) to head (2151d48).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/117/graphs/tree.svg?width=650&height=150&src=pr&token=9KM610P5A4&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research)](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) ```diff @@ Coverage Diff @@ ## main #117 +/- ## ======================================= Coverage 70.09% 70.09% ======================================= Files 17 17 Lines 602 602 Branches 59 59 ======================================= Hits 422 422 Misses 180 180 ```