search

compiler-research / xeus-cpp

Jupyter kernel for the C++ programming language
BSD 3-Clause "New" or "Revised" License
17 stars 24 forks source link

Added pull_request_template.md #118

Closed mcbarton closed 3 months ago

mcbarton commented 3 months ago

This PR adds a basic pull request template to the repo. @vgvassilev @anutosh491 This PR is ready for review.

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.08%. Comparing base (6692a45) to head (09a7f08). Report is 12 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/118/graphs/tree.svg?width=650&height=150&src=pr&token=9KM610P5A4&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research)](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) ```diff @@ Coverage Diff @@ ## main #118 +/- ## ========================================== + Coverage 70.09% 75.08% +4.98% ========================================== Files 17 17 Lines 602 602 Branches 59 59 ========================================== + Hits 422 452 +30 + Misses 180 150 -30 ``` [see 3 files with indirect coverage changes](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/118/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) [see 3 files with indirect coverage changes](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/118/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research)
anutosh491 commented 3 months ago

Well tough to comment on what sort of PR template we need (and if we need one) cause I've not seen any other xues stack have one :|

mcbarton commented 3 months ago

@JohanMabille can you review this PR for me?

mcbarton commented 3 months ago

@vgvassilev can you see if you can get this PR looked at?

mcbarton commented 3 months ago

@JohanMabille I have removed the checklist section and tests section. This should address all your comments. Are you happy with it now?

JohanMabille commented 3 months ago

Yep, thanks ;)