search

compiler-research / xeus-cpp

Jupyter kernel for the C++ programming language
BSD 3-Clause "New" or "Revised" License
17 stars 24 forks source link

Add test for xinterpreter #124

Closed tharun571 closed 3 months ago

tharun571 commented 3 months ago

@alexander-penev review please.

github-actions[bot] commented 3 months ago

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] commented 3 months ago

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] commented 3 months ago

clang-tidy review says "All clean, LGTM! :+1:"

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.08%. Comparing base (ef0992a) to head (7fd7b2c). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/124/graphs/tree.svg?width=650&height=150&src=pr&token=9KM610P5A4&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research)](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/124?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) ```diff @@ Coverage Diff @@ ## main #124 +/- ## ======================================= Coverage 75.08% 75.08% ======================================= Files 17 17 Lines 602 602 Branches 59 59 ======================================= Hits 452 452 Misses 150 150 ```
github-actions[bot] commented 3 months ago

clang-tidy review says "All clean, LGTM! :+1:"

tharun571 commented 3 months ago

@anutosh491 this PR covers #114 but there is a possible bug in CppInterOp. Do you want to close the issue with this simple test case or wait till that bug is resolved?

github-actions[bot] commented 3 months ago

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] commented 3 months ago

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] commented 3 months ago

clang-tidy review says "All clean, LGTM! :+1:"

vgvassilev commented 3 months ago

@alexander-penev, ping.

vgvassilev commented 3 months ago

I am wondering why this did not increase code coverage.

tharun571 commented 3 months ago

I am wondering why this did not increase code coverage.

It said it has already been covered, but this is the only piece of code calling that function. And also it shows some code has not been covered even when it has been covered. Maybe codecov is not 100% accurate.

vgvassilev commented 3 months ago

We seem to have that coverage here: https://github.com/compiler-research/xeus-cpp/blob/e4a86ec9c8b1da841b448179203e3d0727474f30/test/test_xcpp_kernel.py#L25

It is good to have it on the other place, too. This explains why we did not see coverage increase.