Closed tharun571 closed 3 months ago
clang-tidy review says "All clean, LGTM! :+1:"
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 82.05%. Comparing base (
7e5b820
) to head (469be10
). Report is 1 commits behind head on main.
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
Looks good to me but I cannot take that decision without @JohanMabille.
@vgvassilev There is a bug at the moment. When the config header file is configured it still has ;dev in the patch variable . Me and @tharun571 have been discussing. I can't see why. Do you see why?
Looks good to me but I cannot take that decision without @JohanMabille.
@vgvassilev There is a bug at the moment. When the config header file is configured it still has ;dev in the patch variable . Me and @tharun571 have been discussing. I can't see why. Do you see why?
Do we parse the list properly the way we do in CppInterOp?
Looks good to me but I cannot take that decision without @JohanMabille.
@vgvassilev There is a bug at the moment. When the config header file is configured it still has ;dev in the patch variable . Me and @tharun571 have been discussing. I can't see why. Do you see why?
Do we parse the list properly the way we do in CppInterOp?
In an identical way as I linked the PR where we parsed it in CppInterOp as a guide. For some reason that isn't obvious to me the patch number still has ;dev .
This ;dev doesn't happen in CppInterOp, as it was the whole reason we parsed it in this way to avoid the ;dev in patch version number, and allowing finding a version number correctly.
Well, something must be different.
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
Well, something must be different.
@vgvassilev A solution to the patch version issue has been found and the PR is ready for review by @JohanMabille
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"