search

compiler-research / xeus-cpp

Jupyter kernel for the C++ programming language
BSD 3-Clause "New" or "Revised" License
17 stars 24 forks source link

Add xeus_zmq_REQUIRED_VERSION cmake #133

Closed mcbarton closed 3 months ago

mcbarton commented 3 months ago

We current set the required version in cmake by a variable for other packages but not xeus-zmq. This PR fixes this, and updates the documentation to make clear 1.0.2 is needed as a minimum and not 1.0.0

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.08%. Comparing base (3ef699d) to head (1cf861a).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/133/graphs/tree.svg?width=650&height=150&src=pr&token=9KM610P5A4&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research)](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) ```diff @@ Coverage Diff @@ ## main #133 +/- ## ======================================= Coverage 75.08% 75.08% ======================================= Files 17 17 Lines 602 602 Branches 59 59 ======================================= Hits 452 452 Misses 150 150 ```
anutosh491 commented 3 months ago

I have two things here 1) Let's wait for the update to xeus 5 PR to go in (will do that by today) and then wait for this PR to build on top of that. 2) Also we need to think if a minimum xeus_zmq version is even required. Cause if we're setting a minimum version for xeus .. that by itself might end up being sufficient. For eg xeus 5.0.0 is only comptabile with xeus-zmq 3.0.0 and xeus 4.0.0 (and above) is only comptabile with xeus-zmq 2.0.0 ... so technically ensuring a lower bound of xeus does ensure a lower bound on xeus-zmq

mcbarton commented 3 months ago

I have two things here

1. Let's wait for the update to xeus 5 PR to go in (will do that by today) and then wait for this PR to build on top of that.

2. Also we need to think if a minimum xeus_zmq version is even required. Cause if we're setting a minimum version for xeus .. that by itself might end up being sufficient. For eg xeus 5.0.0 is only comptabile with xeus-zmq 3.0.0 and xeus 4.0.0 (and above) is only comptabile with xeus-zmq 2.0.0 ... so technically ensuring a lower bound of xeus does ensure a lower bound on xeus-zmq

If xeus-zmq minimum version is not required i'll just drop the 1.0.2 from the cmake and remove the xeus-zmq in the readme.