search

compiler-research / xeus-cpp

Jupyter kernel for the C++ programming language
BSD 3-Clause "New" or "Revised" License
17 stars 24 forks source link

Update clang format spec to c++17 standard #134

Closed mcbarton closed 3 months ago

mcbarton commented 3 months ago

We have the C++ standard in cmake set to c++17 but in the clang format spec its set to c++14 for some reason. This PR just updates the spec to the correct one.

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.08%. Comparing base (3ef699d) to head (44c52c8).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/134/graphs/tree.svg?width=650&height=150&src=pr&token=9KM610P5A4&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research)](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) ```diff @@ Coverage Diff @@ ## main #134 +/- ## ======================================= Coverage 75.08% 75.08% ======================================= Files 17 17 Lines 602 602 Branches 59 59 ======================================= Hits 452 452 Misses 150 150 ```
mcbarton commented 3 months ago

@vgvassilev can you take a look at this change? @anutosh491 would like someone with experience in clang format to review also.