search

compiler-research / xeus-cpp

Jupyter kernel for the C++ programming language
BSD 3-Clause "New" or "Revised" License
17 stars 24 forks source link

Update issue template #137

Closed mcbarton closed 3 months ago

mcbarton commented 3 months ago

This PR updates the issue template for the repo to complement the PR which adds a pull request template here https://github.com/compiler-research/xeus-cpp/pull/118

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.41%. Comparing base (13e56df) to head (12b63f3). Report is 5 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/137/graphs/tree.svg?width=650&height=150&src=pr&token=9KM610P5A4&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research)](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/137?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) ```diff @@ Coverage Diff @@ ## main #137 +/- ## ========================================== + Coverage 75.08% 79.41% +4.32% ========================================== Files 17 17 Lines 602 612 +10 Branches 59 59 ========================================== + Hits 452 486 +34 + Misses 150 126 -24 ``` [see 5 files with indirect coverage changes](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/137/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) [see 5 files with indirect coverage changes](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/137/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research)
mcbarton commented 3 months ago

@anutosh491 @JohanMabille @alexander-penev can one you please review this PR and the other one linked?

mcbarton commented 3 months ago

@JohanMabille can you take another look at this PR? I fixed all the issues you raised except switching to Github labels. With regards to the Github labels issue I plan to add a workflow which automatically tags each new issue a 'Needs Review' label (needs creating if you could do this for me since I don't have the permissions to do this). It will then be upto the person who reviews the issue to add the correct labels based on the description of the issue.

vgvassilev commented 3 months ago

Can you try again to create a label? I added you to the repo.

mcbarton commented 3 months ago

Can you try again to create a label? I added you to the repo.

Thank you I am now able to add a label :)

mcbarton commented 3 months ago

@JohanMabille I have now addressed all your issues with this PR and its ready for another review.

JohanMabille commented 3 months ago

Can I suggest to use the label "Needs triage" instead of "Needs review" for new issues? It is more widespread in OSS repos (at least on GH). otherwise, LGTM.

mcbarton commented 3 months ago

Can I suggest to use the label "Needs triage" instead of "Needs review" for new issues? It is more widespread in OSS repos (at least on GH). otherwise, LGTM.

@JohanMabille done.

JohanMabille commented 3 months ago

Thanks!