compiler-research / xeus-cpp

Jupyter kernel for the C++ programming language
BSD 3-Clause "New" or "Revised" License
17 stars 24 forks source link

Added functions to retrieve tag files/configs #143

Closed anutosh491 closed 2 months ago

anutosh491 commented 2 months ago

Description

Please include a summary of changes, motivation and context for this PR. We should be dependent on compile time definitions for fetching tagfiles and we should be using prefix_path from xeus to do the following at runtime as mentioned in the issue. Hence I've added relevant functions in the xutils.hpp file for the same.

Fixes #54

Type of change

Please tick all options which are relevant.

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.13%. Comparing base (edd830f) to head (85f201d).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/143/graphs/tree.svg?width=650&height=150&src=pr&token=9KM610P5A4&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research)](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/143?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) ```diff @@ Coverage Diff @@ ## main #143 +/- ## ========================================== + Coverage 82.05% 82.13% +0.08% ========================================== Files 17 17 Lines 613 627 +14 Branches 59 61 +2 ========================================== + Hits 503 515 +12 - Misses 110 112 +2 ``` | [Files](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/143?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) | Coverage Δ | | |---|---|---| | [src/xinspect.hpp](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/143?src=pr&el=tree&filepath=src%2Fxinspect.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research#diff-c3JjL3hpbnNwZWN0LmhwcA==) | `83.19% <100.00%> (ø)` | | | [src/xutils.cpp](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/143?src=pr&el=tree&filepath=src%2Fxutils.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research#diff-c3JjL3h1dGlscy5jcHA=) | `80.95% <85.71%> (+2.38%)` | :arrow_up: | | [Files](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/143?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) | Coverage Δ | | |---|---|---| | [src/xinspect.hpp](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/143?src=pr&el=tree&filepath=src%2Fxinspect.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research#diff-c3JjL3hpbnNwZWN0LmhwcA==) | `83.19% <100.00%> (ø)` | | | [src/xutils.cpp](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/143?src=pr&el=tree&filepath=src%2Fxutils.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research#diff-c3JjL3h1dGlscy5jcHA=) | `80.95% <85.71%> (+2.38%)` | :arrow_up: |
github-actions[bot] commented 2 months ago

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] commented 2 months ago

clang-tidy review says "All clean, LGTM! :+1:"

anutosh491 commented 2 months ago

Thanks @JohanMabille for the review. Let's go ahead and merge this. I'll try to quickly address the above TODO in a dedicated PR :)

github-actions[bot] commented 2 months ago

clang-tidy review says "All clean, LGTM! :+1:"

SylvainCorlay commented 2 months ago

This PR would probably be worth porting to xeus-cling.

anutosh491 commented 2 months ago

Sure I can look into it !