Closed anutosh491 closed 2 months ago
Attention: Patch coverage is 87.50000%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 82.13%. Comparing base (
edd830f
) to head (85f201d
).
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
Thanks @JohanMabille for the review. Let's go ahead and merge this. I'll try to quickly address the above TODO in a dedicated PR :)
clang-tidy review says "All clean, LGTM! :+1:"
This PR would probably be worth porting to xeus-cling.
Sure I can look into it !
Description
Please include a summary of changes, motivation and context for this PR. We should be dependent on compile time definitions for fetching tagfiles and we should be using prefix_path from xeus to do the following at runtime as mentioned in the issue. Hence I've added relevant functions in the xutils.hpp file for the same.
Fixes #54
Type of change
Please tick all options which are relevant.