search

compiler-research / xeus-cpp

Jupyter kernel for the C++ programming language
BSD 3-Clause "New" or "Revised" License
17 stars 24 forks source link

Removed dependency on cppzmq #148

Closed anutosh491 closed 2 months ago

anutosh491 commented 2 months ago

Description

After updating to xeus 5, I think we can drop cppzmq as a dependency

Type of change

Please tick all options which are relevant.

github-actions[bot] commented 2 months ago

clang-tidy review says "All clean, LGTM! :+1:"

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.05%. Comparing base (cbb440a) to head (65dc4f7).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/148/graphs/tree.svg?width=650&height=150&src=pr&token=9KM610P5A4&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research)](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/148?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) ```diff @@ Coverage Diff @@ ## main #148 +/- ## ======================================= Coverage 82.05% 82.05% ======================================= Files 17 17 Lines 613 613 Branches 59 59 ======================================= Hits 503 503 Misses 110 110 ``` | [Files](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/148?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) | Coverage Δ | | |---|---|---| | [src/main.cpp](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/148?src=pr&el=tree&filepath=src%2Fmain.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research#diff-c3JjL21haW4uY3Bw) | `42.85% <ø> (ø)` | | | [Files](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/148?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) | Coverage Δ | | |---|---|---| | [src/main.cpp](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/148?src=pr&el=tree&filepath=src%2Fmain.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research#diff-c3JjL21haW4uY3Bw) | `42.85% <ø> (ø)` | |