compiler-research / xeus-cpp

Jupyter kernel for the C++ programming language

BSD 3-Clause "New" or "Revised" License

17 stars 24 forks source link

Restoring old config file #150

Closed anutosh491 closed 2 months ago

anutosh491 commented 2 months ago

Description

Addressing this comment raised by Johan

Type of change

Please tick all options which are relevant.

[ ] Bug fix
[ ] New feature
[ ] Added/removed dependencies
[ ] Required documentation updates

github-actions[bot] commented 2 months ago

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] commented 2 months ago

clang-tidy review says "All clean, LGTM! :+1:"

vgvassilev commented 2 months ago

I am lost. Why do we undo the work being done in this area?

JohanMabille commented 2 months ago

As said in the original PR, the building tool should not inject anything in the source code, this makes the code depending on the building tool. The original PR was merged to get the inspect feature work until we find a better solution. Now that we have one, we don't need the build tool to inject anything in the source code anymore and we can revert to the original behavior.

vgvassilev commented 2 months ago

As said in the original PR, the building tool should not inject anything in the source code, this makes the code depending on the building tool. The original PR was merged to get the inspect feature work until we find a better solution. Now that we have one, we don't need the build tool to inject anything in the source code anymore and we can revert to the original behavior.

Ok, good. I misread the pull request on my phone. Apologies. LGTM!