search

compiler-research / xeus-cpp

Jupyter kernel for the C++ programming language
BSD 3-Clause "New" or "Revised" License
17 stars 24 forks source link

Refactoring some utilities #153

Open anutosh491 opened 1 month ago

anutosh491 commented 1 month ago

Few utilities that we use are already implemented and tested through xeus. So we can just get rid of them !

anutosh491 commented 1 month ago

We should also be able to used the get_start_message function instead of the following https://github.com/compiler-research/xeus-cpp/blob/4745f724d3b2fdd674a1a46270f27972caf5984b/src/main.cpp#L109-L114

github-actions[bot] commented 1 month ago

clang-tidy review says "All clean, LGTM! :+1:"

anutosh491 commented 1 month ago

Looked straightforward but for some reason the test_xcpp_kernel.py test fails for some reason. Need to have a look into it

anutosh491 commented 1 month ago

@vgvassilev @mcbarton I think this might have something to do with the patches in CppInterOp (y'all could help by confirming) cause through backtrace we get 

error: error reading '/Users/runner/micromamba/envs/xeus-cpp/include': Is a directory
1 error generated.
Error: signal 11:
0   libxeus-cpp.0.5.0dev.dylib          0x000000010d492fbe _ZN4xcpp7handlerEi + 46
1   libsystem_platform.dylib            0x00007ff809df75ed _sigtramp + 29
2   ???                                 0x0000000000000004 0x0 + 4
3   libclangCppInterOp.18.1.dylib       0x0000000117a94620 _ZN5clang17IncrementalParserC2ERNS_11InterpreterENSt3__110unique_ptrINS_16CompilerInstanceENS3_14default_deleteIS5_EEEERN4llvm11LLVMContextERNS9_5ErrorE + 208
4   libclangCppInterOp.18.1.dylib       0x0000000117a97cca _ZN5clang11InterpreterC2ENSt3__110unique_ptrINS_16CompilerInstanceENS1_14default_deleteIS3_EEEERN4llvm5ErrorE + 346
5   libclangCppInterOp.18.1.dylib       0x0000000117a97f44 _ZN5clang11Interpreter6createENSt3__110unique_ptrINS_16CompilerInstanceENS1_14default_deleteIS3_EEEE + 84
6   libclangCppInterOp.18.1.dylib       0x0000000117a78e42 _ZN6compat22createClangInterpreterERNSt3__16vectorIPKcNS0_9allocatorIS3_EEEE + 386
7   libclangCppInterOp.18.1.dylib       0x0000000117a78a73 _ZN3Cpp11InterpreterC2EiPKPKcS2_RKNSt3__16vectorINS5_10shared_ptrIN5clang19ModuleFileExtensionEEENS5_9allocatorISA_EEEEPvb + 883
8   libclangCppInterOp.18.1.dylib       0x0000000117a6d3c9 CreateInterpreter + 1833
9   libxeus-cpp.0.5.0dev.dylib          0x000000010d456c44 _Z17createInterpreterRKNSt3__16vectorIPKcNS_9allocatorIS2_EEEE + 1492