search

compiler-research / xeus-cpp

Jupyter kernel for the C++ programming language
BSD 3-Clause "New" or "Revised" License
20 stars 24 forks source link

Reduce repetition ci #63

Closed mcbarton closed 6 months ago

mcbarton commented 6 months ago

This PR removes duplication within the ci Fixes https://github.com/compiler-research/xeus-cpp/issues/42

mcbarton commented 6 months ago

@vgvassilev This PR is ready for review. I don't know where it specifically addresses what you wanted in the issue, but I have tried to remove repetition in the ci.

vgvassilev commented 6 months ago

Nice! Any chance to incorporate the wasm build? It seems quite different...

mcbarton commented 6 months ago

Nice! Any chance to incorporate the wasm build? It seems quite different...

It may be possible, but I'd advise against it. I think the ci is clearer with the wasm and non wasm builds separate.

vgvassilev commented 6 months ago

Nice! Any chance to incorporate the wasm build? It seems quite different...

It may be possible, but I'd advise against it. I think the ci is clearer with the wasm and non wasm builds separate.

Ok, makes sense. Let's get this one in.