search

compiler-research / xeus-cpp

Jupyter kernel for the C++ programming language
BSD 3-Clause "New" or "Revised" License
17 stars 24 forks source link

Update ci Ubuntu to 24.04 #74

Closed mcbarton closed 4 months ago

mcbarton commented 4 months ago

This PR updates the Ubuntu used in the ci to the latest version (24.04). The random added line is to check that I didn't break the clang tidy ci by updating to a newer Ubuntu.

mcbarton commented 4 months ago

Converting to draft since although Ubuntu 24.04 are listed as available, the workflow isn't able to find a runner. At least not on a fast timescale.

mcbarton commented 4 months ago

@vgvassilev @alexander-penev Can one of you manually reactivate the workflow? The runners should be available now according to this blog post https://github.blog/changelog/2024-05-14-github-hosted-runners-public-beta-of-ubuntu-24-04-is-now-available/

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.66%. Comparing base (aa77879) to head (118b2e2).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/74/graphs/tree.svg?width=650&height=150&src=pr&token=9KM610P5A4&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research)](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/74?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) ```diff @@ Coverage Diff @@ ## main #74 +/- ## ======================================= Coverage 53.66% 53.66% ======================================= Files 15 15 Lines 600 600 Branches 0 59 +59 ======================================= Hits 322 322 Misses 278 278 ``` | [Files](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/74?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) | Coverage Δ | | |---|---|---| | [src/xutils.cpp](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/74?src=pr&el=tree&filepath=src%2Fxutils.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research#diff-c3JjL3h1dGlscy5jcHA=) | `78.57% <ø> (ø)` | | | [Files](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/74?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) | Coverage Δ | | |---|---|---| | [src/xutils.cpp](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/74?src=pr&el=tree&filepath=src%2Fxutils.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research#diff-c3JjL3h1dGlscy5jcHA=) | `78.57% <ø> (ø)` | |
github-actions[bot] commented 4 months ago

clang-tidy review says "All clean, LGTM! :+1:"

mcbarton commented 4 months ago

@vgvassilev @alexander-penev can one of you merge this PR now the new runners are available?

mcbarton commented 4 months ago

@anutosh491 @JohanMabille can one of you review this PR?

mcbarton commented 4 months ago

@anutosh491 Thanks for reviewing and approving so fast. Are you able to merge the PR?