search

compiler-research / xeus-cpp

Jupyter kernel for the C++ programming language
BSD 3-Clause "New" or "Revised" License
20 stars 24 forks source link

Jupyter lite integration #98

Closed mcbarton closed 5 months ago

mcbarton commented 5 months ago

The purpose of this PR is debug and hopefully fix the issue in https://github.com/compiler-research/xeus-cpp/issues/61.

Fixes https://github.com/compiler-research/xeus-cpp/issues/61

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.66%. Comparing base (aa77879) to head (d730578).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/98/graphs/tree.svg?width=650&height=150&src=pr&token=9KM610P5A4&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research)](https://app.codecov.io/gh/compiler-research/xeus-cpp/pull/98?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=compiler-research) ```diff @@ Coverage Diff @@ ## main #98 +/- ## ======================================= Coverage 53.66% 53.66% ======================================= Files 15 15 Lines 600 600 ======================================= Hits 322 322 Misses 278 278 ```
mcbarton commented 5 months ago

@vgvassilev This PR to me suggests there is no issue with Jupyter Lite integration. I added to the ci the instructions to build/test a kernel with Jupyter Lite without making a website, and if you look at the ci, it builds without error, picking up the kernels that have been built.

davy39 commented 5 months ago

Thanks for your work. I did try the build getting it in this artifact, but I'm not able to run C++ code with it, not even declaring variables. Am doing something wrong ?