compilerla / compiler.la

Compiler's website
https://compiler.la
Apache License 2.0
4 stars 2 forks source link

Create 2024-03-11-transportation-round-up.md #178

Closed laneymangan closed 7 months ago

laneymangan commented 7 months ago

@AnthonyRollins can you take a look when you have a minute? this is a work in progress (I still want to add photos, tweak a few things, etc) but figured I'd go ahead and pull you in now so you have access for whenever you find some time

netlify[bot] commented 7 months ago

Deploy Preview for compilerla ready!

Name Link
Latest commit eeee94869f37a512861f51ac520cf40405a9481f
Latest deploy log https://app.netlify.com/sites/compilerla/deploys/65ef735821190200086bb56a
Deploy Preview https://deploy-preview-178--compilerla.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 7 months ago

Deploy Preview for compilerla ready!

Name Link
Latest commit f3d7a068cf14085d072530b01be11dc8b16f3dbe
Latest deploy log https://app.netlify.com/sites/compilerla/deploys/65f3458204b26400081f4392
Deploy Preview https://deploy-preview-178--compilerla.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

angela-tran commented 7 months ago

@laneymangan I'm not sure if you were wanting your post to be hidden, but I noticed your post isn't showing up on the preview site because its date is set in the future.

From the Netlify deploy logs:

4:11:47 PM: $ jekyll build
4:11:47 PM: Configuration file: /opt/build/repo/_config.yml
4:11:47 PM:             Source: /opt/build/repo
4:11:47 PM:        Destination: /opt/build/repo/_site
4:11:47 PM:  Incremental build: disabled. Enable with --incremental
4:11:47 PM:       Generating...
4:11:47 PM:           Skipping: _posts/2024-03-11-transportation-round-up.md has a future date
4:11:47 PM:                     done in 0.308 seconds.
4:11:47 PM:  Auto-regeneration: disabled. Use --watch to enable.
4:11:47 PM: ​
4:11:47 PM: (build.command completed in 802ms)
4:11:47 PM: ​
4:11:48 PM: (Netlify Build completed in 1.1s)
4:11:48 PM: Section completed: building
4:11:53 PM: Finished processing build request in 51.912s

The part to note is this line: Skipping: _posts/2024-03-11-transportation-round-up.md has a future date.

laneymangan commented 7 months ago

@angela-tran I changed the date to today, did that fix it?

angela-tran commented 7 months ago

@angela-tran I changed the date to today, did that fix it?

Yes, very nice!

laneymangan commented 7 months ago

@compilerla/engineering (cc @angela-tran) ready for approval and merging! Let me know if there are any code errors or anything else needed from me. Thank you!

angela-tran commented 7 months ago

@laneymangan I think the /assets/blog/jessica-sullivan.jpg file isn't being used anywhere, so can you delete that one? You should be able to do that from the "Files changed" tab in this PR and use "Delete file".

image

laneymangan commented 7 months ago

@angela-tran hm, doesn't look like I have permissions to delete

image
angela-tran commented 7 months ago

How about from here: https://github.com/laneymangan/compiler.la/blob/patch-2/assets/blog/jessica-sullivan.jpg?

image

laneymangan commented 7 months ago

@angela-tran that worked!

angela-tran commented 7 months ago

@laneymangan I'm glad that one lets you delete! I think you need to commit the deletion though 😅

laneymangan commented 7 months ago

@angela-tran whoops. done!

angela-tran commented 7 months ago

@AnthonyRollins Since you had requested changes on this PR, merging is blocked until you approve it as well

image