search

compilerla / compiler.la

Compiler's website
https://compiler.la
Apache License 2.0
4 stars 2 forks source link

Create 2024-03-22-Civic-Tech-Career-Resources.md #182

Closed laneymangan closed 5 months ago

laneymangan commented 5 months ago

Prepping our Civic Tech Career Resources blog post to be posted on Monday

netlify[bot] commented 5 months ago

Deploy Preview for compilerla ready!

Name Link
Latest commit 0c13080446ab4eada5518ea727c229248c36c033
Latest deploy log https://app.netlify.com/sites/compilerla/deploys/65fe12d88009b80008b0e884
Deploy Preview https://deploy-preview-182--compilerla.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 5 months ago

Deploy Preview for compilerla ready!

Name Link
Latest commit 25349a352eea66426533d240be08926eac9262b6
Latest deploy log https://app.netlify.com/sites/compilerla/deploys/660483f906437600082b17fe
Deploy Preview https://deploy-preview-182--compilerla.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

AnthonyRollins commented 5 months ago

@laneymangan FYI - the excerpt section appears to have the language from creating blog posts - see screenshot

Screenshot 2024-03-22 at 4 46 35 PM
laneymangan commented 5 months ago

@AnthonyRollins thanks! I haven't filled in the front matter yet so when I do I'll be sure to update that

vykster commented 5 months ago

@laneymangan apologies for the late request, but can we removed the justice tech newsletter? it looks like it hasn't been active in almost a year.

laneymangan commented 5 months ago

@compilerla/engineering this is ready for review/approval!

laneymangan commented 5 months ago

This looks good to me, but I think @AnthonyRollins and/or @vykster should approve too?

FYI I'm about to do another run-through to double-check that all the links are accurate so no need for others to spend time on that but other edits/approvals are welcome!

Also, totally unrelated to this post, but it seems like we could tighten up the styles for blog posts, there's a lot of empty space i.e. between headings and sections. Will file an issue for that.

Thanks! That would be great

thekaveman commented 5 months ago

@laneymangan some general practice guidance for PRs on GitHub: when a PR is opened for review, typically the PR should be "ready" from the author's perspective. The only changes to the PR after review should be to address review feedback. This is because every change dismisses previous reviews/approvals, and the whole cycle starts over again.

There is an option to open a PR in "Draft" mode, which is a great way to share an early version while you are still working on it. And then once you've done all your checks and edits and etc., opening for review signals to everyone that the PR is assumed to be in a final state and could be merged as-is if approved.

When you go to open the PR, the green button has a drop-down where you can select "Create draft pull request":

image

Then once you're ready for review, you can click that button in the bottom of the PR:

image

This notifies all reviewers and again signals that the author thinks this PR is ready to be merged.

laneymangan commented 5 months ago

@laneymangan some general practice guidance for PRs on GitHub: when a PR is opened for review, typically the PR should be "ready" from the author's perspective. The only changes to the PR after review should be to address review feedback. This is because every change dismisses previous reviews/approvals, and the whole cycle starts over again.

There is an option to open a PR in "Draft" mode, which is a great way to share an early version while you are still working on it. And then once you've done all your checks and edits and etc., opening for review signals to everyone that the PR is assumed to be in a final state and could be merged as-is if approved.

@thekaveman Ahhh yes this is exactly what I need! As I'm still getting used to this process I've found it helpful to start the Github process, get input, make changes, etc until it's where we want it to be, so the draft option seems perfect for that. Ideally, the workflow will be that we will do all editing in google docs before starting the PR, but for now, it's good to know I can start a draft when needed. Thanks!!

thekaveman commented 5 months ago

@laneymangan I should have noted that you can also put an existing PR into draft state using this somewhat hidden link up near the reviewers pane on the right:

image

You can always go back and forth between draft/not draft for any PR.

laneymangan commented 5 months ago

@thekaveman any way we can merge this without Vyki's approval? (at Vyki's request) CC @AnthonyRollins