compilerla / compiler.la

Compiler's website
https://compiler.la
Apache License 2.0
4 stars 2 forks source link

Feat: "What We've Done" section - first two cards #220

Closed angela-tran closed 2 months ago

angela-tran commented 2 months ago

Part of #212

This PR implements the "What We've Done" section with just the first two cards.

Dev analysis of spacing and decisions to round:

Desktop non-image card Mobile non-image card
angela-tran commented 2 months ago

Rebased onto latest feat/our-work

angela-tran commented 2 months ago

Sorry, found one more spacing thing to fix

angela-tran commented 2 months ago

🙏

angela-tran commented 2 months ago

This is going to be tricky, but I think ideally these Outcome section headers / sections should line up (independent of the size of the description above).

I noticed that too just yesterday while looking at Figma. I agree it'll be tricky... I haven't thought of a way to do it yet. 🤔

edit: maybe we can set a minimum height on things? idk

thekaveman commented 2 months ago

I wonder if @machikoyasuda has any ideas?

machikoyasuda commented 2 months ago

This is going to be tricky, but I think ideally these Outcome section headers / sections should line up (independent of the size of the description above).

I noticed that too just yesterday while looking at Figma. I agree it'll be tricky... I haven't thought of a way to do it yet. 🤔

edit: maybe we can set a minimum height on things? idk

Yeah, a min-height with a percentage would work - only when the screen width is wide enough / containers are set to be side by side:

image image

Sidenote: I think there's something funky going on with the responsiveness. At a certain width, the layout goes down to 1 container per row, but if you go further - it goes to 2 containers per row again.

image
angela-tran commented 2 months ago

@machikoyasuda is helping with the alignment of card contents

machikoyasuda commented 2 months ago
image image